Skip to content
This repository has been archived by the owner on Sep 11, 2023. It is now read-only.

multiple input data files for pv #562

Merged
merged 25 commits into from
Apr 4, 2022
Merged

multiple input data files for pv #562

merged 25 commits into from
Apr 4, 2022

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Dec 21, 2021

Pull Request

Description

PV data can have two datasources

add legacy config code - issue to remove #631

update on_premise.yaml - Need PV from 2020 and 2021 from pv output.org

Fixes #554

How Has This Been Tested?

  • unittests

  • ran preparel_ml_script.py using gcp.yaml (not on leonardo)

  • added tests for old pv confgiruation

  • No

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield self-assigned this Dec 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2021

Codecov Report

Merging #562 (49521d8) into main (2d09fbd) will increase coverage by 0.10%.
The diff coverage is 98.41%.

@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
+ Coverage   93.21%   93.32%   +0.10%     
==========================================
  Files          45       45              
  Lines        2993     3041      +48     
==========================================
+ Hits         2790     2838      +48     
  Misses        203      203              
Impacted Files Coverage Δ
...wcasting_dataset/data_sources/pv/pv_data_source.py 97.53% <97.29%> (+0.34%) ⬆️
nowcasting_dataset/config/model.py 93.53% <100.00%> (+0.67%) ⬆️
nowcasting_dataset/consts.py 100.00% <100.00%> (ø)
...wcasting_dataset/data_sources/datasource_output.py 88.23% <100.00%> (ø)
nowcasting_dataset/manager/base.py 98.14% <100.00%> (+0.10%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@peterdudfield peterdudfield added this to the v17 dataset milestone Dec 21, 2021
@peterdudfield peterdudfield marked this pull request as ready for review December 21, 2021 14:46
Copy link
Member

@JackKelly JackKelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few comments. Nothing major 🙂

Thanks loads for tackling this - it'll be great to have all this lovely PV data for training!

nowcasting_dataset/config/model.py Outdated Show resolved Hide resolved
nowcasting_dataset/config/model.py Outdated Show resolved Hide resolved
nowcasting_dataset/config/model.py Outdated Show resolved Hide resolved
nowcasting_dataset/data_sources/pv/pv_data_source.py Outdated Show resolved Hide resolved
nowcasting_dataset/data_sources/pv/pv_data_source.py Outdated Show resolved Hide resolved
nowcasting_dataset/data_sources/pv/pv_data_source.py Outdated Show resolved Hide resolved
nowcasting_dataset/data_sources/pv/pv_data_source.py Outdated Show resolved Hide resolved
nowcasting_dataset/data_sources/pv/pv_data_source.py Outdated Show resolved Hide resolved
nowcasting_dataset/data_sources/pv/pv_data_source.py Outdated Show resolved Hide resolved
nowcasting_dataset/config/on_premises.yaml Outdated Show resolved Hide resolved
@JackKelly JackKelly changed the title first try and making multiple input data files for pv first try at making multiple input data files for pv Feb 18, 2022
@peterdudfield peterdudfield changed the title first try at making multiple input data files for pv multiple input data files for pv Apr 4, 2022
@peterdudfield peterdudfield merged commit 15c56c2 into main Apr 4, 2022
@peterdudfield peterdudfield deleted the issue/554-both-pv branch April 4, 2022 14:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

include PV data from _both_ PassivSystems and PVOutput.org
3 participants