This repository has been archived by the owner on Sep 11, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #562 +/- ##
==========================================
+ Coverage 93.21% 93.32% +0.10%
==========================================
Files 45 45
Lines 2993 3041 +48
==========================================
+ Hits 2790 2838 +48
Misses 203 203
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
JackKelly
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few comments. Nothing major 🙂
Thanks loads for tackling this - it'll be great to have all this lovely PV data for training!
Thanks Jack for the suggested changes Co-authored-by: Jack Kelly <[email protected]>
# Conflicts: # scripts/generate_data_for_tests/get_test_data.py
JackKelly
changed the title
first try and making multiple input data files for pv
first try at making multiple input data files for pv
Feb 18, 2022
# Conflicts: # requirements.txt
peterdudfield
changed the title
first try at making multiple input data files for pv
multiple input data files for pv
Apr 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
PV data can have two datasources
add legacy config code - issue to remove #631
update on_premise.yaml - Need PV from 2020 and 2021 from pv output.org
Fixes #554
How Has This Been Tested?
unittests
ran preparel_ml_script.py using gcp.yaml (not on leonardo)
added tests for old pv confgiruation
No
Yes
Checklist: