This repository has been archived by the owner on Sep 11, 2023. It is now read-only.
Convert NWP grib files to Zarr intermediate #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackKelly
added
enhancement
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…otebook so will definitely break auto checks
for more information, see https://pre-commit.ci
…sk does not help.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…ad of the writing process. May fail becuase it may unblock reader processes in the wrong order.
…is that it takes about 6 seconds. Too slow
| ) | ||
|
|
||
|
|
||
| @click.command() |
| 4) Use multiple worker processes. Each worker process is given a list of | ||
| grib files associated with a single NWP init datetime. The worker process loads these grib | ||
| files and does some simple post-processing, and then the worker process appends to the | ||
| destination zarr. |
peterdudfield
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
For me it looks all very good. I like the docs and comments you have done. That makes it a lot easier.
There's probably a few things like
- tests,
- move functions to their own file
- hard coded values, move to their own file
- add a bit more logging
but I think these can all wait until Move our data download & conversion scripts into separate repos (preparing for production) #359
jacobbieker
approved these changes
Nov 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Write a script to convert NWP native files (in
gribformat) to a Zarr.Fixes #344
This script ended up being more complex than I was imagining!
Later, as part of #359, this script will be moved into its own repository, and the functions will be put into a nice little Python package (with unittests!)
How Has This Been Tested?
The script runs successfully and has converted all our NWP data to Zarr.
Checklist: