Change Pydantic from_orm to model_validate (#284) #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e related to Forecast model (#284)
…lue models (#284) Updated from_orm class method in Forecast and ForecastValue models, so they call model_validate instead of the deprecated from_orm method. Created a class method model_validate in Forecast and ForecastValue models, so they work as from_orm class methods worked.
Updated Forecast and ForecastValue models from_orm call to model_validate call.
Updated Forecast and ForecastValue models from_orm call to model_validate call.
Created model_validate_latest method that does the same thing as from_orm_latest. So it is consistent to the syntax of pydantic V2
…st and ForecastValue models
for more information, see https://pre-commit.ci
|
Hello, The tests failed because I use "from_attributes: bool | None = None" typing annotation, as I assumed the project used python >= 3.10. I can change that annotation for compatibility issues if it is not the case. |
Thanks so much for this, really helpful doing all this. |
peterdudfield
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR refers to the issue #284 : from_orm method is deprecated in pydantic V2
I updated the models and tests that called the deprecated pydantic method from_orm. They now call model_validate as advised in the Pydantic migration guide.
The Forecast and ForecastValue models had methods that overwrote the pydantic from_orm method. I leaved those methods in the models, but they now call model_validate instead of from_orm. I also created model_validate methods for those classes, having the same behavior as calling from_orm.
How Has This Been Tested?
I tested via the test framework as seen in the readme file. As the modification are minors, it should be enough.
Checklist: