filter more in the pass

[peterdudfield]

Pull Request

Description

We get a bug in the read function if both start_datetime and created_utc_limit are set

Before we had

query = query.filter(model.target_time >= start_datetime)
query = query.filter(model.created_utc <= created_utc_limit)
query = query.filter(ForecastSQL.created_utc >= start_datetime - timedelta(1day))

This was a problem if the created_utc_limit was more than a day before the start_datetime

we now have

query = query.filter(model.target_time >= start_datetime)
query = query.filter(model.created_utc <= created_utc_limit)
query = query.filter(ForecastSQL.created_utc >= min(start_datetime,created_utc_limit) - timedelta(1day))

Helps with openclimatefix/uk-pv-national-gsp-api#327

How Has This Been Tested?

CI tests

• added a test, that fails without the change

• Yes

Checklist:

• My code follows OCF's coding style guidelines
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have checked my code and corrected any misspellings

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 94.75%. Comparing base (fc3d90c) to head (53ec51d).
Report is 2 commits behind head on main.

❗ Current head 53ec51d differs from pull request most recent head 2111cce. Consider uploading reports for the commit 2111cce to get more accurate results

Files	Patch %	Lines
nowcasting_datamodel/read/read.py	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
- Coverage   94.81%   94.75%   -0.06%     
==========================================
  Files          24       24              
  Lines        1523     1525       +2     
==========================================
+ Hits         1444     1445       +1     
- Misses         79       80       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.