56 add maxvit blocks for interior of model #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Raahul-Singh
force-pushed
the
56-add-maxvit-blocks-for-interior-of-model
branch
from
8ff1116 to
0ba8289
Compare
|
Test fails seem unrelated to this MR |
Yeah, I need to update some of those tests to pass, I would say either just add a skip for now, or I'll try to get around to it this week. |
|
I've tested the code and added TODOs wherever I feel more scrutiny is required. |
Raahul-Singh
changed the title
jacobbieker
approved these changes
Nov 6, 2023
|
Thanks @jacobbieker ! |
|
@jacobbieker sir, where can I make changes to fix issue #58 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adds MaxVit Block, and it's subblocks for Metnet 3
Fixes #56
How Has This Been Tested?
Added new shape tests for each new subblock
Checklist: