Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use reuse able workflow #9

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Use reuse able workflow #9

merged 4 commits into from
Jan 26, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Jan 26, 2024 •
edited
Loading

Pull Request

Description

Use reusuable workflow for lint and test

How Has This Been Tested?

CI tests it

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield
Copy link
Contributor Author

Hey @confusedmatrix do you mind using this in ruvnl-consumer-app

@confusedmatrix
Copy link
Contributor

Hey @confusedmatrix do you mind using this in ruvnl-consumer-app

Yep, sure thing

confusedmatrix
confusedmatrix approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@confusedmatrix confusedmatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@confusedmatrix confusedmatrix merged commit 99c63d9 into main Jan 26, 2024
3 checks passed
@peterdudfield peterdudfield deleted the use-reuse-able-workflow branch January 26, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@confusedmatrix confusedmatrix confusedmatrix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @confusedmatrix