Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up cache data #139

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Speed up cache data #139

merged 3 commits into from
Nov 26, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Nov 26, 2024 •
edited
Loading

Pull Request

Description

  • only late nwp once
  • only load satellite data if neded

How Has This Been Tested?

Ci tests, tested locally

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as ready for review November 26, 2024 14:41
@peterdudfield peterdudfield requested a review from Sukh-P November 26, 2024 14:42
Sukh-P
Sukh-P approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@Sukh-P Sukh-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice changes

@peterdudfield peterdudfield merged commit de7ee12 into main Nov 26, 2024
3 checks passed
@peterdudfield peterdudfield deleted the speed-up-cache-data branch November 26, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sukh-P Sukh-P Sukh-P approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @Sukh-P