Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for runs #134

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Fix for runs #134

merged 3 commits into from
Nov 20, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Nov 20, 2024 •
edited
Loading

Pull Request

Description

fix for number of runs - dont use len(sites)
and got tests passing for new model

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as ready for review November 20, 2024 21:47
@peterdudfield peterdudfield merged commit d1be6f6 into main Nov 20, 2024
3 checks passed
@peterdudfield peterdudfield deleted the fix-for-runs branch November 20, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peterdudfield