Issue/solar night time #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterdudfield
commented
Nov 20, 2024
| # filter out night time | ||
| if self.asset_type == SiteAssetType.pv: | ||
| if self.asset_type == SiteAssetType.pv.name: |
There was a problem hiding this comment.
this is the main bit of code
peterdudfield
commented
Nov 20, 2024
| for idx in range(8): | ||
| values_df["forecast_power_kw"][idx] -= ( | ||
| values_df["forecast_power_kw"][idx] - final_gen_points | ||
| ) * smooth_values[final_gen_index + idx] | ||
| log.debug(f"New values are {values_df['forecast_power_kw']}") | ||
|
|
||
| if self.asset_type == "solar": |
There was a problem hiding this comment.
This didnt do anything due to above if loop
peterdudfield
commented
Nov 20, 2024
| @@ -167,7 +172,8 @@ def set_night_time_zeros(batch, preds, sun_elevation_limit=0.0): | |||
| sun_elevation = sun_elevation.detach().cpu().numpy() | |||
|
|
|||
| # expand dimension from (1,197) to (1,197,7), 7 is due to the number plevels | |||
| sun_elevation = np.repeat(sun_elevation[:, :, np.newaxis], 7, axis=2) | |||
| n_plevels = preds.shape[2] | |||
| sun_elevation = np.repeat(sun_elevation[:, :, np.newaxis], n_plevels, axis=2) | |||
There was a problem hiding this comment.
this is the only other relevant change
ADIMANV
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
fix for making sure soalr forcast are zero at night time
There was a bug, Need to change
self.asset_type == SiteAssetType.pv:toself.asset_type == SiteAssetType.pv.name:#129
How Has This Been Tested?
CI tests
Checklist: