pvsite-datamodel integration & fake forecasts #1
Conversation
…put the forecasts for sites
confusedmatrix
changed the title
|
To get the tests running, I think we need a later version of this github reusable workflow - https://github.com/openclimatefix/india-forecast-app/blob/main/.github/workflows/ci.yml#L37 |
This line refers to the docker-release reusable workflow which I believe is already pinned to the latest version v1.2.0 The github action doesn't currently run as the github action secrets aren't yet set. Would you be able to set the following secrets for me please? DOCKERHUB_USERNAME |
|
secrets added, add 1.8.1 is the latest |
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
|
|
||
| .PHONY: lint | ||
| lint: | ||
| poetry run ruff $(SRC) | ||
| poetry run black --check $(SRC) | ||
| poetry run isort --check $(SRC) |
There was a problem hiding this comment.
do you want to keep this in? I have found them quite useful in the past and they then are the same as the CI
There was a problem hiding this comment.
I was getting a conflict between ruff and black, so just stuck with ruff - as far as I understand, ruff is a drop in replacement for black anyway
| """ | ||
|
|
||
| sites = get_sites_by_country(db_session, country="india") | ||
|
|
There was a problem hiding this comment.
could we add loggin statement here, saying found X sites
india_forecast_app/app.py
Outdated
| log.info(f"Running model for site={site_id}") | ||
| forecast_values = run_model(model=model, site_id=site_id, timestamp=timestamp) | ||
|
|
||
| if forecast_values is not None: |
There was a problem hiding this comment.
can you add a else, and say forecast values were None, or something like that
Pull Request
Description
N.B This work is dependent on openclimatefix/pv-site-datamodel#97
Still TODO:
Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: