-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPU option in Docker file #98
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
=======================================
Coverage 79.57% 79.57%
=======================================
Files 13 13
Lines 426 426
=======================================
Hits 339 339
Misses 87 87 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Thanks for it! Just a few small tweaks if possible, then we can merge it in
environment_cpu.yml
Outdated
- zarr | ||
- h3-py | ||
- numpy | ||
- torch==2.2.2+cpu -f https://download.pytorch.org/whl/torch_stable.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can set pytorch to be cpuonly with this instead, might be less brittle than this other way
- torch==2.2.2+cpu -f https://download.pytorch.org/whl/torch_stable.html | |
- cpuonly |
RUN conda update -n base -c defaults conda | ||
|
||
# Check if CUDA is available and accordingly choose env | ||
RUN cuda=$(command -v nvcc > /dev/null && echo "true" || echo "false") \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Co-authored-by: Jacob Bieker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for this
Pull Request
Description
added condition to check for cuda availability and accordingly creates environment
Fixes #97
How Has This Been Tested?
by building image in non cuda device
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: