Fengwu ghr #114
Merged
Fengwu ghr #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbieker
reviewed
Jun 12, 2024
| height, width, | ||
| method: str = "cubic"): | ||
| # TODO 1. CPU only | ||
| # 2. The mesh is a rectangle, not a sphere |
There was a problem hiding this comment.
It being a rectangle is fine, it has to be for the MetaModel to take it as an image. So I think this is great!
| squared_distance = (diff * diff).sum(dim=-1, keepdim=True) | ||
| weights = 1.0 / torch.clamp(squared_distance, min=1e-16) | ||
|
|
||
| # print((x[x_idx]*weights).shape) |
There was a problem hiding this comment.
I would remove commented out code like this when you finish with the changes, just to keep it a bit cleaner.
|
@all-contributors please add @rnwzd for code |
|
I've put up a pull request to add @rnwzd! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.