Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add auth0 #85

Merged
merged 2 commits into from
Oct 16, 2023
Merged

add auth0 #85

merged 2 commits into from
Oct 16, 2023

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Oct 13, 2023

Pull Request

Description

Add auth0 using streamlit, now log in the usual way. Also, only emails with openclimatefix can assess this.

I had to add another Auth0 https://manage.auth0.com/dashboard/eu/nowcasting-dev/applications/VqaPLArS3LG97MF4uY6RSQmJV0hiNwxN/settings. I kinda of like having it as a differen application, rather than all in one

Need to add

  • AUTH0_CLIENT_ID
  • AUTH0_DOMAIN
    to enviornment

Helps with #70
Screenshot 2023-10-13 at 10 10 20

Screenshot 2023-10-13 at 10 11 00 Screenshot 2023-10-13 at 10 10 15

How Has This Been Tested?

Tested it locally

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link
Collaborator

@devsjc devsjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good PR description too!

Copy link
Collaborator

@rachel-labri-tipton rachel-labri-tipton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @peterdudfield, this looks good but I wasn't able to run the code locally. aside from clientid and domain, is there anything else that needs to go in the .env file? thanks!

@peterdudfield
Copy link
Contributor Author

hey @peterdudfield, this looks good but I wasn't able to run the code locally. aside from clientid and domain, is there anything else that needs to go in the .env file? thanks!

AUTH0_CLIENT_ID
AUTH0_DOMAIN
which you can get from https://manage.auth0.com/dashboard/eu/nowcasting-dev/applications/VqaPLArS3LG97MF4uY6RSQmJV0hiNwxN/settings

@peterdudfield peterdudfield merged commit 9e40aef into main Oct 16, 2023
@peterdudfield peterdudfield deleted the add-auth0 branch October 16, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants