Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to add map on the dashboard #246

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Conversation

ADIMANV
Copy link
Contributor

@ADIMANV ADIMANV commented Jan 9, 2025

Pull Request

Description

This fix adds map on the dashboard, for the user to see if the actual location of the sites,
image

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@ADIMANV ADIMANV requested a review from peterdudfield January 9, 2025 07:18
src/mlmodel.py Outdated Show resolved Hide resolved
src/mlmodel.py Outdated
all_sites = all_sites.sort_values(by="client_site_name")

st.table(all_sites.style.applymap(color_survived, subset=["last_generation_datetime"]))

# 2. display all models
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have you delete display all models?

src/mlmodel.py Outdated Show resolved Hide resolved
@ADIMANV ADIMANV merged commit 1f0ea67 into main Jan 10, 2025
2 checks passed
@ADIMANV ADIMANV deleted the Adding-map-on-the-dashboard branch January 10, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants