Rename MAE plot line from "Daily Total MAE" to "Latest Forecast" #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterdudfield
approved these changes
Jan 6, 2025
|
thank you |
|
@all-contributors please add @MAYANK12SHARMA for doc |
|
I've put up a pull request to add @MAYANK12SHARMA! 🎉 |
|
Thank you so much for merging, @peterdudfield! 🙌 I’m excited to contribute more in the future. |
|
Hi @peterdudfield, I’ve created another PR (#244) for issues #243 and #226. Could you please take a look at it as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR resolves the issue of renaming "Daily Total MAE" to "Latest Forecast" in the MAE by Horizon plot as described in issue #193 . The changes ensure consistent terminology and improve clarity in the plot labels.
Fixes #193
How Has This Been Tested?
Run it locally
The changes were tested to ensure functionality and consistency.
Steps to Reproduce:
You can reproduce the changes by opening the file located at
src\plots\forecast_horizon.pyand inspecting line number 27. When you create theforecast_horizonchart, you will see the updated label, "Latest Forecast," displayed correctly.Checklist: