Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End date + NMAE by capacity #156

Merged
merged 4 commits into from
May 17, 2024
Merged

End date + NMAE by capacity #156

merged 4 commits into from
May 17, 2024

Conversation

ADIMANV
Copy link
Contributor

@ADIMANV ADIMANV commented May 17, 2024

Pull Request

Description

Code changes adds an end date to the forecast + name on the webpage
These changes are to the #154 #153

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link
Contributor

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small change, but this looks great

@peterdudfield
Copy link
Contributor

Could you resolve conflicts
and in the description add #154 #153

@ADIMANV ADIMANV merged commit ecca278 into main May 17, 2024
1 check passed
@peterdudfield
Copy link
Contributor

@all-contributors please add @ADIMANV for code

@peterdudfield peterdudfield deleted the End-date-webpage branch May 17, 2024 14:11
Copy link
Contributor

@peterdudfield

I've put up a pull request to add @ADIMANV! 🎉

@peterdudfield peterdudfield mentioned this pull request May 17, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants