Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to save WindNet batches #99

Merged
merged 11 commits into from
Nov 27, 2023
Merged

Conversation

jacobbieker
Copy link
Member

@jacobbieker jacobbieker commented Nov 24, 2023

Pull Request

Description

Adds Windnet batch creation for wind forecasting

Fixes #

How Has This Been Tested?

Unit test

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (7eee4bb) 49.93% compared to head (2fdb5d9) 50.08%.

Files Patch % Lines
pvnet/data/wind_datamodule.py 52.17% 22 Missing ⚠️
pvnet/data/utils.py 83.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   49.93%   50.08%   +0.14%     
==========================================
  Files          23       26       +3     
  Lines        1642     1691      +49     
==========================================
+ Hits          820      847      +27     
- Misses        822      844      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobbieker jacobbieker requested a review from dfulu November 27, 2023 11:18
@jacobbieker jacobbieker marked this pull request as ready for review November 27, 2023 11:18
Copy link
Member

@dfulu dfulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

@jacobbieker jacobbieker merged commit a2be583 into main Nov 27, 2023
5 checks passed
@jacobbieker jacobbieker deleted the jacob/windnet-batch-creation branch November 27, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants