Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and reformat of site_example_configuration #292

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

felix-e-h-p
Copy link

Simply updating the specified config regarding format alteration largely

@felix-e-h-p felix-e-h-p requested a review from Sukh-P December 18, 2024 12:26
@Sukh-P
Copy link
Member

Sukh-P commented Dec 18, 2024

This looks great thanks, I think a few more files will need updating, the streamed/pre_saved batches config files and also I think the pinned version of ocf-data-sampler will need updating, would be good to add this to this PR for completeness

Copy link
Member

@Sukh-P Sukh-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for updating these, great work!

@felix-e-h-p felix-e-h-p merged commit 430e1d7 into dev-data-sampler Dec 18, 2024
3 checks passed
@Sukh-P
Copy link
Member

Sukh-P commented Dec 18, 2024

@all-contributors please add @felix-e-h-p for code.

Copy link
Contributor

@Sukh-P

I've put up a pull request to add @felix-e-h-p! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants