Add sample saving for Site Dataset #290
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sukh-P
commented
Dec 17, 2024
for more information, see https://pre-commit.ci
…x/PVNet into site-data-sampling
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
20 tasks
| ) | ||
| batch = next(iter(dm.train_dataloader())) | ||
| return batch | ||
| # TODO update this test once we add the loading logic for the Site dataset |
There was a problem hiding this comment.
I cant work out if we should merge before doing this, im not sure there. Relates to openclimatefix/ocf-data-sampler#99
peterdudfield
requested changes
Dec 20, 2024
There was a problem hiding this comment.
Code looks all good. I wonder if we should od openclimatefix/ocf-data-sampler#99 first, then add some test cases in here, just to be double sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Inclues:
ocf-data-samplerSitetorch datasetocf-data-samplerocf-data-samplerHow Has This Been Tested?
This is a sister PR to https://github.com/openclimatefix/ocf-data-sampler/pull/82/files, ran the save_samples script with the changes in that PR and validated the samples being produced looked correct.