Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pv padding and hf model handling to backtest_sites.py #262

Merged
merged 11 commits into from
Oct 18, 2024

Conversation

AUdaltsova
Copy link
Contributor

@AUdaltsova AUdaltsova commented Oct 17, 2024

Pull Request

Description

  • Added an option to use a model from HuggingFace
  • Added datapipe to pad pv data so that sun position is created correctly (see this issue in dpipes)
  • Fixed conversion to nanoseconds warning

How Has This Been Tested?

Ran small backtest sthat require pv padding with a local and a HF model

  • Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

Checked that with new coded padding the forecast is identical to what a manually padded dataset produces.

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@AUdaltsova AUdaltsova requested a review from Sukh-P October 17, 2024 15:38
scripts/backtest_sites.py Outdated Show resolved Hide resolved
scripts/backtest_sites.py Outdated Show resolved Hide resolved
scripts/backtest_sites.py Outdated Show resolved Hide resolved
Copy link
Member

@Sukh-P Sukh-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant work adding these fixes/features in!

scripts/backtest_sites.py Outdated Show resolved Hide resolved
scripts/backtest_sites.py Outdated Show resolved Hide resolved
scripts/backtest_sites.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
scripts/backtest_sites.py Outdated Show resolved Hide resolved
scripts/backtest_sites.py Outdated Show resolved Hide resolved
scripts/backtest_sites.py Outdated Show resolved Hide resolved
@AUdaltsova AUdaltsova merged commit eb8b445 into main Oct 18, 2024
3 checks passed
@AUdaltsova AUdaltsova deleted the backtest_sites_patch branch October 18, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants