-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pv padding and hf model handling to backtest_sites.py #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Sukh-P
reviewed
Oct 17, 2024
Sukh-P
reviewed
Oct 17, 2024
AUdaltsova
commented
Oct 17, 2024
Sukh-P
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant work adding these fixes/features in!
AUdaltsova
commented
Oct 17, 2024
AUdaltsova
commented
Oct 17, 2024
Co-authored-by: Sukhil Patel <[email protected]>
AUdaltsova
commented
Oct 17, 2024
AUdaltsova
commented
Oct 18, 2024
AUdaltsova
commented
Oct 18, 2024
AUdaltsova
commented
Oct 18, 2024
AUdaltsova
commented
Oct 18, 2024
AUdaltsova
commented
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
How Has This Been Tested?
Ran small backtest sthat require pv padding with a local and a HF model
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checked that with new coded padding the forecast is identical to what a manually padded dataset produces.
Checklist: