Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #259

Merged
merged 10 commits into from
Nov 13, 2024
Merged

Bug fixes #259

merged 10 commits into from
Nov 13, 2024

Conversation

dfulu
Copy link
Member

@dfulu dfulu commented Oct 7, 2024

I encountered some bugs when pushing the latest version of the UK model to huggingface. These fixes were required for it to go through

  • Type hinting changes due to limitations with typer
  • Command line _ to -
  • Change in looping over the dictionary keys since we can't loop over the keys in a dict whilst editing that dict

@dfulu dfulu requested a review from Sukh-P October 7, 2024 10:41
Copy link
Member

@Sukh-P Sukh-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating these!

@dfulu dfulu merged commit 1fda52f into main Nov 13, 2024
2 of 3 checks passed
@dfulu dfulu deleted the bug_fixes branch November 13, 2024 11:24
dfulu added a commit that referenced this pull request Nov 13, 2024
* Bug fixes (#259)

* model checkpoint bug fixes

* Bump version: 3.0.63 → 3.0.64 [skip ci]

---------

Co-authored-by: BumpVersion Action <bumpversion@github-actions>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants