Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wandb artifact saving in base_model.py #254

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Fix wandb artifact saving in base_model.py #254

merged 1 commit into from
Sep 23, 2024

Conversation

AUdaltsova
Copy link
Contributor

Pull Request

Description

Changed val results artifact name for wandb to not contain restricted characters. Otherwise was getting this error:

Artifact name may only contain alphanumeric characters, dashes, underscores, and dots. Invalid name: validation_results_epoch=0

How Has This Been Tested?

Ran training with the fix and synced the result to wandb, now the artifacts get saved

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@AUdaltsova AUdaltsova merged commit ad30b23 into main Sep 23, 2024
5 checks passed
@AUdaltsova AUdaltsova deleted the wandb-patch branch September 23, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdudfield peterdudfield peterdudfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AUdaltsova @peterdudfield