Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix history bug and add bells in analysis.py #241

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Fix history bug and add bells in analysis.py #241

merged 3 commits into from
Aug 12, 2024

Conversation

AUdaltsova
Copy link
Contributor

@AUdaltsova AUdaltsova commented Aug 5, 2024

Pull Request

Description

Analysis.py results were inconsistent because run.history() was pulling 500 random steps instead of the whole history. Fixed that.

Bells and whistles:

  • Added epoch number to the legend label for easier assessment. May be redundant, happy to remove it

How Has This Been Tested?

Ran analysis.py several times for the same set of runs to make sure it gave consistent results; separately tested that run.lastHistoryStep was working as expected

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@AUdaltsova AUdaltsova requested a review from Sukh-P August 5, 2024 15:18
@AUdaltsova AUdaltsova marked this pull request as ready for review August 5, 2024 15:19
@AUdaltsova
Copy link
Contributor Author

@peterdudfield turns out I made the change and never merged, mind taking a quick look when you have a minute?

@AUdaltsova AUdaltsova merged commit eaefc7b into main Aug 12, 2024
3 checks passed
@AUdaltsova AUdaltsova deleted the analysis-bug branch August 12, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants