Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HF upload script and model cards #239

Merged
merged 7 commits into from
Aug 7, 2024
Merged

Update HF upload script and model cards #239

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1a5cfdc
Update default for wandb_ids
Jul 24, 2024
e2b27ac
Update type hints
Aug 6, 2024
91e26ad
Fix model cards
Aug 7, 2024
8c00aab
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 7, 2024
cc9cc41
linting
Aug 7, 2024
8742ebc
Correct model cards
Aug 7, 2024
5e07cc1
Remove duplicated parameter
Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/checkpoint_to_huggingface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
def push_to_huggingface(
checkpoint_dir_paths: list[str],
val_best: bool = True,
wandb_ids: Optional[list[str]] = None,
wandb_ids: list[str] = [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity: why not Optional anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a mistake, added it back in, thanks! Also updated the type hint slightly to the more up to date python way so we don't need to use Optional

local_path: Optional[str] = None,
push_to_hub: bool = True,
):
Expand Down
Loading