-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use concurrent batch pipeline for ~30x speed up #236
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
=======================================
Coverage ? 58.48%
=======================================
Files ? 29
Lines ? 1879
Branches ? 0
=======================================
Hits ? 1099
Misses ? 780
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Looks good! |
Might be worth getting @AUdaltsova and @Sukh-P to review also as they use datapipes quite a bit |
Great work adding this in and getting the speedup! Just checking has this been reran and tested locally? |
for more information, see https://pre-commit.ci
…ix/PVNet into concurrent_pipeline
Yeh, it has been tested locally on a small set of examples. I'm going to leave it open for now since I am making concurrent batches to train on and Zak is doing a backtest. Just in case more bugs come out of the woodwork during those |
Add the PVNet concurrent datapipe to the concurrent batch creation and backtest scripts. The new data is already in
ocf_datapipes
and is about 30x faster than the old datapipe for creating concurrent batches