Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script config parameters #232

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Update script config parameters #232

merged 2 commits into from
Jul 2, 2024

Conversation

Sukh-P
Copy link
Member

@Sukh-P Sukh-P commented Jul 2, 2024

Pull Request

Description

Updating the config parameters to the dataloader in the save_concurrent_batches script to match the structure in the config example files and the save_batches script.

Also updated an incorrect install command for ocf_datapipes in the README

How Has This Been Tested?

Ran some batch creation with the changes.

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@Sukh-P Sukh-P requested review from peterdudfield and dfulu July 2, 2024 09:56
@Sukh-P Sukh-P marked this pull request as ready for review July 2, 2024 09:58
Copy link
Member

@dfulu dfulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Sukh-P Sukh-P merged commit e715313 into main Jul 2, 2024
3 checks passed
@Sukh-P Sukh-P deleted the update-script branch July 2, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants