fix 60 min hardcode NWP resolution in multimodal.py #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix hardcoded time resolution for NWPs
Description
NWP time resolution was hard-coded to be 60 minutes.
ocf_datapipes
had been updated already, this is a matching update forPVNet
.pvnet/models/multimodal/multimodal.py
:nwp_interval_minutes
as an optional argumentnwp_interval_minutes
if not passed for backward compatibilityDictConfig
and notint
configs.example/model/multimodal.yaml
:nwp_interval_minutes
PVNet/README.md
:configs.example
Fixes #181
How Has This Been Tested?
Trained with the updated
multimodal.py
Ran run.py with both updated and original configs to ensure both are working
Yes
Checklist: