Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 60 min hardcode NWP resolution in multimodal.py #208

Merged
merged 8 commits into from
Jun 7, 2024
Merged

Conversation

AUdaltsova
Copy link
Contributor

@AUdaltsova AUdaltsova commented Jun 3, 2024

Fix hardcoded time resolution for NWPs

Description

NWP time resolution was hard-coded to be 60 minutes. ocf_datapipes had been updated already, this is a matching update for PVNet.

  • In pvnet/models/multimodal/multimodal.py:
    • Added nwp_interval_minutes as an optional argument
    • Added creation of nwp_interval_minutes if not passed for backward compatibility
    • Updated some type hints to reflect that NWP parameters are passed as DictConfigand not int
    • Some typos fixed in the comments
  • In configs.example/model/multimodal.yaml:
    • Added nwp_interval_minutes
  • In PVNet/README.md:
    • Updated dead links and fixed some typos
    • Re-written batch creation and training instructions to reflect updates in configs.example

Fixes #181

How Has This Been Tested?

  • Trained with the updated multimodal.py

  • Ran run.py with both updated and original configs to ensure both are working

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

AUdaltsova and others added 8 commits June 3, 2024 13:39
NWP resolution fixed to pull form config; if config values not available, default 60 min resolution supplied for backward compatibility
Update example configs to accommodate setting different time resolution for NWPs
@AUdaltsova AUdaltsova marked this pull request as ready for review June 5, 2024 16:57
@AUdaltsova AUdaltsova merged commit 1c72529 into main Jun 7, 2024
3 checks passed
@AUdaltsova AUdaltsova deleted the NWP_patch branch June 14, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Train model with MERRA2 as NWP input
2 participants