Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

india 005 experiments - more nwps #203

Merged
merged 5 commits into from
Jun 3, 2024
Merged

india 005 experiments - more nwps #203

merged 5 commits into from
Jun 3, 2024

Conversation

peterdudfield
Copy link
Contributor

Pull Request

Description

Add india experiments for add more nwp variables from ECMWF

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield requested a review from Sukh-P May 30, 2024 17:46
@peterdudfield peterdudfield changed the title add india 005 experiments india 005 experiments - more nwps May 30, 2024
Sukh-P
Sukh-P approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@Sukh-P Sukh-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice experiment writeup!

Out of interest has a similar experiment been done on PVNet before (either for India or the UK)?

@peterdudfield
Copy link
Contributor Author

Nice experiment writeup!

Out of interest has a similar experiment been done on PVNet before (either for India or the UK)?

Thanks @Sukh-P

This is for India Windnet. I dont belive this has been done for India PVnet nor UK. I think there was some playing with UK at some point, but im not sure where the results are. I like putting the small experiments results in the repo, as they we dont easily lose them

@peterdudfield peterdudfield merged commit 6f84e4e into main Jun 3, 2024
3 checks passed
@peterdudfield peterdudfield deleted the india-nwp-experiments branch June 3, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sukh-P Sukh-P Sukh-P approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @Sukh-P