Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test batches and make weighted loss general to device #117

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Conversation

dfulu
Copy link
Member

@dfulu dfulu commented Jan 8, 2024

  • Fix batches for datapipes 3.1.5
  • Minor fix to make sure the weighted loss will work regardless of the device used

@dfulu dfulu changed the title Make weighted loss general to device Fix test batches and make weighted loss general to device Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b74b1d) 57.62% compared to head (b2d0e30) 57.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   57.62%   57.62%           
=======================================
  Files          26       26           
  Lines        1706     1706           
=======================================
  Hits          983      983           
  Misses        723      723           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfulu dfulu requested a review from jacobbieker January 9, 2024 09:24
Copy link
Member

@jacobbieker jacobbieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dfulu dfulu merged commit 0fc19bc into main Jan 9, 2024
5 checks passed
@dfulu dfulu deleted the fix_tests branch January 9, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants