Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/rm nowcasting utils #100

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Issue/rm nowcasting utils #100

merged 3 commits into from
Nov 27, 2023

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Nov 27, 2023 •
edited
Loading

Pull Request

Description

How Has This Been Tested?

CI tests + new ones

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1848eea) 49.93% compared to head (bd79763) 50.51%.
Report is 1 commits behind head on main.

Files Patch % Lines
pvnet/models/base_model.py 25.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   49.93%   50.51%   +0.57%     
==========================================
  Files          23       23              
  Lines        1642     1663      +21     
==========================================
+ Hits          820      840      +20     
- Misses        822      823       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dfulu
dfulu approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@dfulu dfulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterdudfield peterdudfield merged commit fc82c92 into main Nov 27, 2023
5 checks passed
@peterdudfield peterdudfield deleted the issue/rm-nowcasting-utils branch November 27, 2023 15:18
jacobbieker pushed a commit that referenced this pull request Nov 28, 2023
@peterdudfield @pre-commit-ci @jacobbieker
Issue/rm nowcasting utils (#100)
e462b5e 
* rm nowcasting_utils

* move WeightLoss class + test, use common_metrics

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfulu dfulu dfulu approved these changes

@jacobbieker jacobbieker jacobbieker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove nowcasting_utils
3 participants
@peterdudfield @jacobbieker @dfulu