Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #20

Merged
merged 8 commits into from
Jun 18, 2024
Merged

Update #20

merged 8 commits into from
Jun 18, 2024

Conversation

dfulu
Copy link
Member

@dfulu dfulu commented Jun 18, 2024

PVNet_summation has become quite out of date w.r.t. PVNet. This pull request brings it back up to date

@peterdudfield
Copy link
Contributor

PVNet_summation has become quite out of date w.r.t. PVNet. This pull request brings it back up to date

Have you run training with this? If so, all good to merge

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.44%. Comparing base (fd32406) to head (68f8495).
Report is 5 commits behind head on main.

Files Patch % Lines
pvnet_summation/models/base_model.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #20       +/-   ##
===========================================
- Coverage   59.53%   35.44%   -24.10%     
===========================================
  Files           6        3        -3     
  Lines         472      316      -156     
===========================================
- Hits          281      112      -169     
- Misses        191      204       +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfulu dfulu merged commit 8592272 into main Jun 18, 2024
4 of 5 checks passed
@dfulu dfulu deleted the update branch June 18, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants