Remove properties #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…/PVNet_summation into remove_properties
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 59.36% 59.53% +0.17%
==========================================
Files 6 6
Lines 470 472 +2
==========================================
+ Hits 279 281 +2
Misses 191 191 ☔ View full report in Codecov by Sentry. |
| else: | ||
| self.num_output_features = self.forecast_len_30 | ||
|
|
||
| if self.pvnet_model.use_quantile_regression: |
There was a problem hiding this comment.
whats the difference between these two, could you add a comment
| @@ -1,6 +1,5 @@ | |||
| ocf_datapipes==3.2.* | |||
| pvnet==2.6.* | |||
| ocf_ml_metrics==0.0.* | |||
| pvnet==3.0.* | |||
There was a problem hiding this comment.
worth pinning a bit more? or maybe not. Perhaps fine like this, but in pvnet_app could be fully pinned
There was a problem hiding this comment.
Yeh I'd prefer to pin in pvnet_app. I think thats better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Similar to openclimatefix/PVNet#149
I've been having trouble instantiating models with hydra because of these properties. It is simpler to remove them and replace them with attributes instead.
Also removing some requirements which aren't used by the summation model