Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old database: major change #73

Merged
merged 15 commits into from
Jan 4, 2024
Merged

remove old database: major change #73

merged 15 commits into from
Jan 4, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Dec 22, 2023

Pull Request

Description

Only save (and read) data to new database

  • removed nowcasting_datamodel so only using pvsite-datamodel
  • only saves to one database

How Has This Been Tested?

  • CI tests
  • run locally pvoutput.org
  • run locally SS

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (356247b) 96.67% compared to head (f96add7) 97.50%.

Files Patch % Lines
pvconsumer/save.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   96.67%   97.50%   +0.83%     
==========================================
  Files           6        6              
  Lines         301      281      -20     
==========================================
- Hits          291      274      -17     
+ Misses         10        7       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pvconsumer/app.py Outdated Show resolved Hide resolved
@peterdudfield peterdudfield requested a review from devsjc January 3, 2024 17:54
@peterdudfield peterdudfield merged commit 894dbc6 into main Jan 4, 2024
5 checks passed
@peterdudfield peterdudfield deleted the issue/rm-old-db branch January 4, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants