Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing importing scheme for plugins to address #91 #121

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rivasd
Copy link

@rivasd rivasd commented Apr 23, 2019

This should fix #91 that is still not working in 1.0.2 by moving plugin_interface inside the plugins folder and fixing importing syntax accordingly

@codecov-io
Copy link

codecov-io commented Apr 23, 2019

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   37.46%   37.46%           
=======================================
  Files           9        9           
  Lines        1588     1588           
=======================================
  Hits          595      595           
  Misses        993      993

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2288eb...3da8042. Read the comment docs.

@daniellasry
Copy link
Contributor

Our python developer, @andreaortuno , is currently working on removing the yapsy plugin manager. Instead, we'll have simple Cyton & Ganglion classes with the same functions.

In the interim, this fix is definitely welcome. I will test it out shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugin_interface
3 participants