-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin_interface #91
Comments
I hope somebody responds, I have the same issue. EDIT: Well, @mesca, I got a temporary solution working, atleast for now. The installer provided in the repo does not seem to install plugin_interfaces. So, here are the steps I did :
Hope you find this helpful! |
If this works for you, please close the issue. |
Thanks, but your solution and mine are just workarounds, not real fixes. The point is that I don't see the reason for importing ALL the plugins and dependencies in the Anyway, you should probably submit a PR, since at least that makes it useable. Having to manually copying and editing files defeat the purpose of a pip package ;) |
I agree that having to manually copy and paste and edit files is definitely not something that the user should have to do. However, I wonder what exactly causes this issue. Is the |
Well, I think it's because |
By |
Yes, but also the normal Python package in the |
Oh, I'm sorry I didn't get you the first time. Anyway, I have submitted a PR. Also, here is a version I made that you can install (still from the .whl file there). So you have to install manually. Here is the link -> https://github.com/tushar-c/openbci-fixed EDIT: To make sure I'm clear, by manually, I mean you have to download, go to where the |
Sounds like we need to add the plugin_interface.py into the package that is published with pypi? |
Probably :) |
any ideas how? |
Since this basically breaks the whole package ( I can't even do |
Just going to confirm that this issue is still present as of today after installing with |
this error occurs on a new install ( fresh vm ubuntu 18.10) same error trying to import anything from the obenbci pkg fails. |
upgrading pip and reinstalling did the trick works fine |
This is still not working for me, and as @rivasd said higher up in this thread, it breaks the whole package. $ pip list
Package Version
-------------- -------
bluepy 1.3.0
future 0.17.1
iso8601 0.1.12
numpy 1.17.2
OpenBCI-Python 1.0.2
pip 19.2.3
pyserial 3.4
PyYAML 5.1.2
setuptools 40.8.0 Running the following code still throws an error: import sys
from openbci import OpenBCIGanglion
def handle_data(sample):
logging.debug(sample)
if __name__ == '__main__':
board = OpenBCIGanglion()
board.start_streaming(handle_data) File "{...}/OpenBCIClient/venv/lib/python3.7/site-packages/openbci/plugins/csv_collect.py", line 6, in <module>
import plugin_interface as plugintypes
ModuleNotFoundError: No module named 'plugin_interface' |
@molguin92 I think that |
When installing from pip,
from openbci import wifi
will give an error:ModuleNotFoundError: No module named 'plugin_interface'
. It is becauseplugin_interface.py
is outside of the package.Commenting the line
from .plugins import *
inopenbci/__init__.py
fixes the problem. I am not familiar with the plugin system, and maybe this quick fix has side-effects. Is there a better way?The text was updated successfully, but these errors were encountered: