fix: remove all unnecessary items (#10)

* Fixed bug where not all required items were deleted from array and replacd deepequal with faster version * Added proper tests * chore: better test * test: add * prefer clone deep Co-authored-by: Ivan Malkov <[email protected]>
openapi-contrib · Jul 2, 2020 · a48ac2a · a48ac2a
1 parent 25198e8
commit a48ac2a
Show file tree

Hide file tree

Showing 7 changed files with 1,109 additions and 1,056 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,2 +1,3 @@
 *.swp
 node_modules
+.idea
diff --git a/index.js b/index.js
@@ -1,6 +1,6 @@
-var deepEqual = require('deep-equal');
+var deepEqual = require('fast-deep-equal');
 var convert = require('./lib/convert');
-var clone = require('clone');
+var clone = require('lodash.clonedeep');
 
 module.exports = openapiSchemaToJsonSchema;
 module.exports.fromSchema = openapiSchemaToJsonSchema;

diff --git a/lib/converters/schema.js b/lib/converters/schema.js
@@ -232,16 +232,15 @@ function convertPatternProperties (schema, handler) {
 }
 
 function cleanRequired (required, properties) {
-	var i = 0
-
 	required = required || []
 	properties = properties || {}
+	let remainedRequired = []
 
-	for (i; i < required.length; i++) {
-		if (properties[required[i]] === undefined) {
-			required.splice(i, 1)
-		}
+	for (let i = 0; i < required.length; i++) {
+    if (properties[required[i]]) {
+      remainedRequired.push(required[i])
+    }
 	}
 
-	return required
+	return remainedRequired
 }