feat: elaborate TODOs #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
civsiv
commented
Mar 28, 2024
| @@ -417,20 +417,24 @@ public Uri RenderOrderId(OrderType orderType, Guid uuid) | |||
| return this.RenderOrderId(new OrderIdComponents { OrderType = orderType, uuid = uuid }); | |||
| } | |||
|
|
|||
| //TODO reduce duplication of the strings / logic below | |||
lukehesluke
approved these changes
Apr 2, 2024
Comment on lines
731
to
732
| // TODO: add this error class to the library | ||
| // CS: Is this still the case? Unclear where this library is, and hard to believe OpenBookingError would not be in the libary |
There was a problem hiding this comment.
I'm not fully sure I understand what this is talking about, so ignore me if this is irrelevant, but it looks like OpenBookingError is part of OpenActive.NET (here).
Could this comment be referring to OpenBookingException? And if so, what library..?
Or maybe it means that there should be a special OnlyBookableOpportunitesPermittedInTestInterfaceError class or something, idk
There was a problem hiding this comment.
Yeh I'm also very confused by the comment. I think OnlyBookableOpportunitesPermittedInTestInterfaceError in OpenActive.Net makes most sense so will amend the comment
OpenActive.Server.NET/CustomBookingEngine/CustomBookingEngine.cs
Outdated
Show resolved
Hide resolved
Comment on lines
360
to
+361
| // TODO: The static example below should come from the database (which doesn't currently support tax) | ||
| // This is because it can be different for each Seller and needs to calculated at the time of booking |
There was a problem hiding this comment.
Could this cause any bugs at present? If yes then maybe should be a GH issue?
* feat: remove remainingAttendeeCapacity and maximumAttendeeCapacity from B response * remove from P response too
Co-authored-by: Luke Winship <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #225