add data refresher, remote storage database toggle #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickevansuk
requested changes
Jul 19, 2021
There was a problem hiding this comment.
As a first pass at this, having not got into the detail of what might be causing the problem, the CI issues point to an issue with database initialisation.
If the tables are wiped or not initialised on startup then the auth will fail (which happens in some cases), and if the tables are wiped then there will be no sessions in the database (which happens in other cases).
Can do a deeper investigation, however thought worth bouncing this back first now that CI is fixed? Should be possible to reproduce this locally by running both projects in SQLite mode and starting one and then the other in either order.
Comment on lines
51
to
84
| db.CreateTable<GrantTable>(); | ||
| db.CreateTable<BookingPartnerTable>(); | ||
| db.CreateTable<SellerTable>(); | ||
| db.CreateTable<ClassTable>(); | ||
| db.CreateTable<OrderTable>(); | ||
| db.CreateTable<OccurrenceTable>(); | ||
| db.CreateTable<FacilityUseTable>(); | ||
| db.CreateTable<SlotTable>(); | ||
| db.CreateTable<OrderItemsTable>(); | ||
| db.CreateTable<SellerUserTable>(); | ||
| } | ||
| else | ||
| { | ||
| if (!db.TableExists<GrantTable>()) | ||
| db.CreateTable<GrantTable>(); | ||
| if (!db.TableExists<BookingPartnerTable>()) | ||
| db.CreateTable<BookingPartnerTable>(); | ||
| if (!db.TableExists<SellerTable>()) | ||
| db.CreateTable<SellerTable>(); | ||
| if (!db.TableExists<ClassTable>()) | ||
| db.CreateTable<ClassTable>(); | ||
| if (!db.TableExists<OrderTable>()) | ||
| db.CreateTable<OrderTable>(); | ||
| if (!db.TableExists<OccurrenceTable>()) | ||
| db.CreateTable<OccurrenceTable>(); | ||
| if (!db.TableExists<FacilityUseTable>()) | ||
| db.CreateTable<FacilityUseTable>(); | ||
| if (!db.TableExists<SlotTable>()) | ||
| db.CreateTable<SlotTable>(); | ||
| if (!db.TableExists<OrderItemsTable>()) | ||
| db.CreateTable<OrderItemsTable>(); | ||
| if (!db.TableExists<SellerUserTable>()) | ||
| db.CreateTable<SellerUserTable>(); | ||
| } |
There was a problem hiding this comment.
Can use db.CreateTableIfNotExists<>(); here to simplify
… Reference table queries
…penActive.Server.NET into feature/ref-impl-db
…penActive.Server.NET into feature/ref-impl-db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soft delete:
New data at edge of window: