chore: Update .NET Framework Version to 4.8.1 #778
Annotations
13 warnings
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
|
|
OpenActive.Server.NET/CustomBookingEngine/CustomBookingEngine.cs#L153
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L38
Avoid empty interfaces
|
|
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L266
Exceptions should be public
|
|
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L266
Add the following constructor to SilentRollbackException: public SilentRollbackException(string message).
|
|
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L266
Add the following constructor to SilentRollbackException: public SilentRollbackException(string message, Exception innerException).
|
|
OpenActive.Server.NET/OpenBookingHelper/Stores/IdempotencyStore.cs#L23
In externally visible method 'string IdempotencyStore.CalculateIdempotencyKey(OrderIdComponents orderId, string orderJson)', validate parameter 'orderId' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument.
|
|
OpenActive.Server.NET/OpenBookingHelper/Stores/IdempotencyStore.cs#L22
Member CalculateIdempotencyKey does not access instance data and can be marked as static (Shared in VisualBasic)
|
|
OpenActive.Server.NET/OpenBookingHelper/Async/AsyncDuplicateLock.cs#L36
Call System.IDisposable.Dispose on object created by 'new SemaphoreSlim(1, 1)' before all references to it are out of scope.
|
|
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L365
Consider calling ConfigureAwait on the awaited task
|
|
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "core.controlled.all-features", "core.controlled.facilityuse-has-slots", "core.controlled.no-auth", "core.controlled.no-payment-reconciliation", "core.controlled.no-tax-calculation", "core.controlled.prepayment-always-required", "core.controlled.single-seller", "core.random.all-features", "core.random.facilityuse-has-slots", "core.random.no-auth", "core.random.no-payment-reconciliation", "core.random.no-tax-calculation", "core.random.prepayment-always-required", "core.random.single-seller".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
This job succeeded
Loading