Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pass tuples to MirrorGroup. #30

Closed
wants to merge 1 commit into from

Conversation

bergmannf
Copy link

Pass a list[str] as the mirrors argument.

Update the logic derived from urlgrabber components to split the
received strings into the three-tuple (host, path, query) as needed.

This partially resolves #29 (4 tests remain failing for me).

Given that this changes code interfacing with urlgrabber I
assume I might also just be using an unsupported version of
that dependency, where the interfaces were changed.

Pass a list[str] as the mirrors argument.

Update the logic derived from `urlgrabber` components to split the
received strings into the three-tuple `(host, path, query)` as needed.
@marcus-h
Copy link
Member

marcus-h commented Dec 12, 2017 via email

@bergmannf bergmannf closed this Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing tests
2 participants