Fix local building in git projects - v2 #1669
Conversation
|
Hello @dmach! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-11-29 15:37:12 UTC |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # because obs_scm store takes precedence as .osc is present | ||
| with open(os.path.join(self.toplevel, ".osc/_project")) as f: | ||
| self._project = f.readline().strip() | ||
| except FileNotFoundError: |
Check notice
Code scanning / CodeQL
Empty except Note
| git_scm.warn_experimental() | ||
| else: | ||
| store = None | ||
| except oscerr.NoWorkingCopy: |
Check notice
Code scanning / CodeQL
Empty except Note
| store = git_scm.GitStore(path, check) | ||
| if print_warnings: | ||
| git_scm.warn_experimental() | ||
| except oscerr.NoWorkingCopy: |
Check notice
Code scanning / CodeQL
Empty except Note
dmach
force-pushed
the
fix_local_build-v2
branch
2 times, most recently
from
104370f to
508ea4c
Compare
The fields were made optional because scmsync packages don't provide them
osc did not find it's store and was unable to run a local build in a project git
dmach
force-pushed
the
fix_local_build-v2
branch
from
508ea4c to
a6db8ad
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1669 +/- ##
==========================================
- Coverage 35.03% 34.06% -0.98%
==========================================
Files 142 142
Lines 20640 21453 +813
==========================================
+ Hits 7232 7308 +76
- Misses 13408 14145 +737 ☔ View full report in Codecov by Sentry. |
No description provided.