Store the container annotation in the "containers" directory #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlschroe
force-pushed
the
master
branch
2 times, most recently
from
d1e8d8b to
b04d220
Compare
Like the OBS worker does.
dmach
requested changes
Sep 16, 2024
Comment on lines
+1326
to
+1327
| if not os.path.exists("containers"): | ||
| os.makedirs("containers") |
There was a problem hiding this comment.
Replace with os.makedirs("containers", exist_ok=True).
Your code is longer and is prone to race conditions.
Comment on lines
+1328
to
+1329
| with open("containers/annotation", "wb") as f: | ||
| f.write(bi.containerannotation.encode()) |
There was a problem hiding this comment.
Wouldn't be better to avoid encoding to bytes?
with open("containers/annotation", "w", encoding="utf-8") as f:
f.write(bi.containerannotation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the OBS worker does.