checkout: allow to checkout obs imported sources of scmsync sources #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @adrianschroeter! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-11-08 07:30:30 UTC |
|
should I do this large re-formating of existing code where the linter complains about? |
dirkmueller
reviewed
Sep 11, 2024
| @@ -5250,6 +5250,8 @@ def do_browse(self, subcmd, opts, *args): | |||
| help='Use server side generated sources instead of local generation.') | |||
| @cmdln.option('-l', '--limit-size', metavar='limit_size', | |||
| help='Skip all files with a given size') | |||
| @cmdln.option('--native-obs-package', action='store_true', | |||
| help='Do not clone native scm repositories: Different representation and you will not be able to submit changes!') | |||
There was a problem hiding this comment.
overindented (should be one space beyond the opening parentheses) and wrapping missing
There was a problem hiding this comment.
yes, but I don't want to become inconsistent with all other options ... let's either change all or none (but I would do it in another commit)
dirkmueller
reviewed
Sep 11, 2024
dirkmueller
reviewed
Sep 11, 2024
This allows to skip the check of obs-scm-bridge and checks out what
is stored in OBS src server.
Note: This is not necessarly the same representation as in git
(.obscpio instead of directories or sub modules).
Also no modification can be committed.
So this is only intended for people who understand the current
internal implementation of the source storage. There is no
guarantee that this won't change.
Checkout of entire project git is not working with this switch, as
the packagelist of osc is empty. It may also make no sense to do
this as it will not perform for large projects.
Co-authored-by: Dirk Mueller <[email protected]>
Co-authored-by: Dirk Mueller <[email protected]>
dmach
force-pushed
the
allow-native-checkout
branch
from
511bc31 to
f4298b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to skip the check of obs-scm-bridge and checks out what is stored in OBS src server.
Note: This is not necessarly the same representation as in git
(.obscpio instead of directories or sub modules).
Also no modification can be committed.
So this is only intended for people who understand the current
internal implementation of the source storage. There is no
guarantee that this won't change.
Checkout of entire project git is not working with this switch, as the packagelist of osc is empty. It may also make no sense to do this as it will not perform for large projects.