Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local building in git projects #1617

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion osc/commandline.py
Original file line number Diff line number Diff line change
Expand Up @@ -7151,7 +7151,10 @@ def do_build(self, subcmd, opts, *args):

if not opts.local_package:
store = osc_store.get_store(Path.cwd(), print_warnings=True)
store.assert_is_package()
if isinstance(store, git_scm.store.GitStore):
opts.local_package = True
else:
store.assert_is_package()

try:
if opts.alternative_project and opts.alternative_project == store.project:
Expand Down
22 changes: 20 additions & 2 deletions osc/git_scm/store.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,17 @@
self.abspath = os.path.abspath(self.path)

# TODO: how to determine if the current git repo contains a project or a package?
self.is_project = False
self.is_package = os.path.exists(os.path.join(self.abspath, ".git"))

# NOTE: we have only one store in project-git for all packages
self._toplevel = self._run_git(["rev-parse", "--show-toplevel"])
config_path = os.path.join(self._toplevel, "_config")
pbuild_path = os.path.join(self._toplevel, "_pbuild")
if self._toplevel == self.abspath and (os.path.isfile(config_path) or os.path.isfile(pbuild_path)):
self.is_project = True
self.is_package = False
else:
self.is_project = False
self.is_package = True

self._package = None
self._project = None
Expand Down Expand Up @@ -68,11 +77,20 @@

@property
def project(self):
if self._project is None:
if self._toplevel:
try:
with open(os.path.join(self._toplevel, '.osc/_project')) as f:
self._project = f.readline().strip()
except FileNotFoundError:

Check notice

Code scanning / CodeQL

Empty except Note

'except' clause does nothing but pass and there is no explanatory comment.
pass

if self._project is None:
# get project from the branch name
branch = self._run_git(["branch", "--show-current"])

# HACK: replace hard-coded mapping with metadata from git or the build service
# NOTE: you never know which git repo is supposed to be used in which project
if branch == "factory":
self._project = "openSUSE:Factory"
else:
Expand Down
12 changes: 12 additions & 0 deletions osc/store.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@


import os
import subprocess
from xml.etree import ElementTree as ET

from . import oscerr
Expand All @@ -29,6 +30,17 @@ def get_store(path, check=True, print_warnings=False):
git_scm.warn_experimental()
else:
store = None
try:
toplevel = subprocess.check_output(["git", "rev-parse", "--show-toplevel"],
encoding="utf-8",
stderr=subprocess.DEVNULL).strip()
if toplevel:
store = git_scm.GitStore(toplevel, check)
if print_warnings:
git_scm.warn_experimental()
except subprocess.CalledProcessError:
# we should distinguish between git cli fails or git is not installed
pass

if not store:
msg = f"Directory '{path}' is not a working copy"
Expand Down
Loading