Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make most of the fields in KeyinfoPubkey and KeyinfoSslcert models optional #1597

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

dmach
Copy link
Contributor

@dmach dmach commented Jul 4, 2024

Fixes: #1596

@pep8speaks
Copy link

pep8speaks commented Jul 4, 2024

Hello @dmach! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 13:14: W291 trailing whitespace
Line 14:14: W291 trailing whitespace
Line 15:14: W291 trailing whitespace
Line 16:14: W291 trailing whitespace
Line 17:14: W291 trailing whitespace
Line 28:14: W291 trailing whitespace
Line 29:14: W291 trailing whitespace
Line 30:14: W291 trailing whitespace
Line 31:14: W291 trailing whitespace
Line 32:14: W291 trailing whitespace
Line 33:14: W291 trailing whitespace
Line 34:14: W291 trailing whitespace
Line 35:14: W291 trailing whitespace
Line 36:14: W291 trailing whitespace

Comment last updated at 2024-07-04 12:25:13 UTC

dmach added 2 commits July 4, 2024 14:24
…tional

The presence of the fields seems to be random and the only truly required field
is the actual public key/cert. Other fields are only for the information.
@dmach dmach force-pushed the keyinfo-minimal-attributes branch from 898abb9 to 52f0766 Compare July 4, 2024 12:25
@dmach dmach merged commit 644c59f into openSUSE:master Jul 4, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Osc build exits with TypeError 'KeyinfoPubkey' if no publickeys are returned by the server
2 participants