Add results --fail-on-error/-F flag
#1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @saschagrunert! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-06-20 07:57:10 UTC |
saschagrunert
force-pushed
the
fail-on-error
branch
4 times, most recently
from
4ad3c3f to
4d00f06
Compare
dmach
requested changes
Jun 7, 2024
saschagrunert
force-pushed
the
fail-on-error
branch
2 times, most recently
from
c368e02 to
84841fc
Compare
This allows to exit with `1` in case any build fails to provide feedback to end-user scripts. Refers to: kubernetes/release#3632 Signed-off-by: Sascha Grunert <[email protected]>
|
I've rebased the PR, resolved conflicts and force-pushed back to your branch. |
|
Thank you @dmach! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to exit with
1in case any build fails to provide feedback to end-user scripts.Refers to: kubernetes/release#3632