Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move most of the OBS SCM code to obs_scm submodule #1536

Merged
merged 7 commits into from
Apr 16, 2024

Conversation

dmach
Copy link
Contributor

@dmach dmach commented Apr 15, 2024

No description provided.

@pep8speaks
Copy link

Hello @dmach! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 226:121: E501 line too long (126 > 120 characters)
Line 239:121: E501 line too long (131 > 120 characters)
Line 283:9: E722 do not use bare 'except'
Line 289:9: E722 do not use bare 'except'
Line 318:13: E722 do not use bare 'except'
Line 339:13: E722 do not use bare 'except'
Line 579:121: E501 line too long (144 > 120 characters)
Line 604:121: E501 line too long (121 > 120 characters)
Line 643:13: E722 do not use bare 'except'
Line 747:121: E501 line too long (121 > 120 characters)
Line 845:13: E722 do not use bare 'except'
Line 1018:121: E501 line too long (122 > 120 characters)
Line 1184:13: E271 multiple spaces after keyword
Line 1269:121: E501 line too long (161 > 120 characters)
Line 1272:121: E501 line too long (181 > 120 characters)
Line 1275:121: E501 line too long (155 > 120 characters)
Line 1276:17: E722 do not use bare 'except'
Line 1278:121: E501 line too long (189 > 120 characters)
Line 1279:21: E722 do not use bare 'except'
Line 1280:121: E501 line too long (175 > 120 characters)
Line 1283:121: E501 line too long (147 > 120 characters)
Line 1285:121: E501 line too long (143 > 120 characters)
Line 1293:121: E501 line too long (128 > 120 characters)
Line 1454:121: E501 line too long (127 > 120 characters)

Line 117:121: E501 line too long (123 > 120 characters)
Line 262:13: E722 do not use bare 'except'
Line 361:121: E501 line too long (127 > 120 characters)
Line 362:121: E501 line too long (129 > 120 characters)
Line 373:25: E722 do not use bare 'except'
Line 384:121: E501 line too long (125 > 120 characters)
Line 398:33: E722 do not use bare 'except'
Line 399:121: E501 line too long (124 > 120 characters)
Line 445:121: E501 line too long (126 > 120 characters)
Line 458:121: E501 line too long (125 > 120 characters)
Line 468:121: E501 line too long (137 > 120 characters)
Line 474:121: E501 line too long (125 > 120 characters)
Line 488:121: E501 line too long (136 > 120 characters)
Line 547:13: E722 do not use bare 'except'

Line 241:121: E501 line too long (217 > 120 characters)
Line 247:121: E501 line too long (123 > 120 characters)

Line 110:9: E722 do not use bare 'except'
Line 302:121: E501 line too long (128 > 120 characters)
Line 338:5: E722 do not use bare 'except'
Line 505:5: E722 do not use bare 'except'
Line 534:5: E722 do not use bare 'except'
Line 544:5: E722 do not use bare 'except'

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@dmach
Copy link
Contributor Author

dmach commented Apr 16, 2024

I'm going to ignore the issues pep8speaks reported, because I'm only moving existing code from core.py to a new submodule.

@dmach dmach merged commit c39b648 into openSUSE:master Apr 16, 2024
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants