Backport several bugfixes from master to 1.6.x-maint branch #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It needs to remove the scmsync tag in package meta in that case (when creating a new package meta based on source). I didn't that global in replace_pkg_meta() on purpose since this should be a case by case decision when it makes sense. We could add this there via an option though. There is another problem in the api that it delivers package meta without title/description elements, but it is not accepting it. This is submitted there via a seperate pull request.
Makes `osc rpmlint` infer the project and package when working from a locally checked out package dir, if two or fewer arguments are passed. All four arguments are still required when called from a location that is not an osc package working copy. This makes the behaviour of `osc rpmlint` similar to `osc buildlogtail`.
…he 'build' command does
Add '--no-debug-packages' option that disables the new behavior. This makes the command consistent with the 'build' command.
|
Hello @dmach! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-04-12 15:26:56 UTC |
This was a bad API, command handlers should return None or an exit code. Anything that returns an actual value belongs to the library instead.
…s that do not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.