Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from _pubkey to _keyinfo #1518

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Move from _pubkey to _keyinfo #1518

merged 4 commits into from
Apr 10, 2024

Conversation

dmach
Copy link
Contributor

@dmach dmach commented Mar 14, 2024

Fixes: #1283

@pep8speaks
Copy link

Hello @dmach! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 36:5: E303 too many blank lines (2)
Line 41:121: E501 line too long (125 > 120 characters)
Line 66:121: E501 line too long (133 > 120 characters)
Line 78:121: E501 line too long (127 > 120 characters)
Line 105:121: E501 line too long (134 > 120 characters)

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0.57803% with 172 lines in your changes are missing coverage. Please review.

Project coverage is 31.27%. Comparing base (7b73fde) to head (7f6c0b3).
Report is 42 commits behind head on master.

Files Patch % Lines
osc/obs_api/keyinfo.py 0.00% 65 Missing ⚠️
osc/obs_api/keyinfo_sslcert.py 0.00% 33 Missing ⚠️
osc/fetch.py 3.03% 32 Missing ⚠️
osc/obs_api/keyinfo_pubkey.py 0.00% 23 Missing ⚠️
osc/commandline.py 0.00% 18 Missing ⚠️
osc/obs_api/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1518      +/-   ##
==========================================
- Coverage   31.48%   31.27%   -0.21%     
==========================================
  Files         103      106       +3     
  Lines       19072    19190     +118     
==========================================
- Hits         6004     6002       -2     
- Misses      13068    13188     +120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

osc/commandline.py Dismissed Show dismissed Hide dismissed
@dmach dmach merged commit d423835 into openSUSE:master Apr 10, 2024
31 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easier to migrate to a new project signing key
3 participants