Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move xml_indent, xml_quote and xml_unquote to osc.util.xml module #1482

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

dmach
Copy link
Contributor

@dmach dmach commented Feb 12, 2024

No description provided.

node.text = None
elif len(node) != 0:
node.text = None
for child in node:

Check failure

Code scanning / CodeQL

Suspicious unused loop iteration variable Error

For loop variable 'child' is not used in the loop body.
osc/_private/api.py Dismissed Show dismissed Hide dismissed
osc/_private/api.py Dismissed Show dismissed Hide dismissed
@dmach dmach force-pushed the util-xml branch 2 times, most recently from 7bc5545 to d5d1a44 Compare February 12, 2024 08:21
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (0f8a843) 31.51% compared to head (556c97d) 31.53%.
Report is 6 commits behind head on master.

Files Patch % Lines
osc/output/input.py 21.87% 25 Missing ⚠️
osc/core.py 5.55% 17 Missing ⚠️
osc/util/xml.py 79.48% 8 Missing ⚠️
osc/commandline.py 25.00% 3 Missing ⚠️
osc/babysitter.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1482      +/-   ##
==========================================
+ Coverage   31.51%   31.53%   +0.01%     
==========================================
  Files          50       51       +1     
  Lines       17908    17938      +30     
==========================================
+ Hits         5643     5656      +13     
- Misses      12265    12282      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmach dmach merged commit d1f4522 into openSUSE:master Feb 12, 2024
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant